Multiple service charge lines are generated unexpectedly when you partly ship a service order in Microsoft Dynamics NAV 2009

Symptoms

Assume that you create service order for a customer who has a service charge specified in Microsoft Dynamics NAV 2009. When you partly ship the service order, multiple service charge lines are generated unexpectedly.This problem occurs in the following products:

Microsoft Dynamics NAV 2009 R2
Microsoft Dynamics NAV 2009 Service Pack 1 (SP1)

Resolution

Hotfix information

A supported hotfix is now available from Microsoft. However, it is only intended to correct the problem that is described in this article. Apply it only to systems that are experiencing this specific problem. This hotfix may receive additional testing. Therefore, if you are not severely affected by this problem, we recommend that you wait for the next Microsoft Dynamics NAV 2009 service pack or the next Microsoft Dynamics NAV version that contains this hotfix. Note In special cases, charges that are ordinarily incurred for support calls may be canceled if a Technical Support Professional for Microsoft Dynamics and related products determines that a specific update will resolve your problem. The usual support costs will apply to additional support questions and issues that do not qualify for the specific update in question.

Installation information

Microsoft provides programming examples for illustration only, without warranty either expressed or implied. This includes, but is not limited to, the implied warranties of merchantability or fitness for a particular purpose. This article assumes that you are familiar with the programming language that is being demonstrated and with the tools that are used to create and to debug procedures. Microsoft support engineers can help explain the functionality of a particular procedure, but they will not modify these examples to provide added functionality or construct procedures to meet your specific requirements.Note Before you install this hotfix, verify that all Microsoft Navision client users are logged off the system. This includes Microsoft Navision Application Services (NAS) client users. You should be the only client user who is logged on when you implement this hotfix.To implement this hotfix, you must have a developer license.We recommend that the user account in the Windows Logins window or in the Database Logins window be assigned the "SUPER" role ID. If the user account cannot be assigned the "SUPER" role ID, you must verify that the user account has the following permissions:

The Modify permission for the object that you will be changing.
The Execute permission for the System Object ID 5210 object and for the System Object ID 9015 object.

Note You do not have to have rights to the data stores unless you have to perform data repair.

Code changes

Note Always test code fixes in a controlled environment before you apply the fixes to your production computers. To resolve the problem, change the code in the CalculateInvoiceDiscount function in the Service-Calc. Discount codeunit (5950) as follows:Existing code 1

LOCAL PROCEDURE CalculateInvoiceDiscount@1(VAR ServHeader@1000 : Record 5900;VAR ServiceLine@1006 : Record 5902;VAR ServiceLine2@1001 : Record 5902);
VAR
TempVATAmountLine@1002 : TEMPORARY Record 290;
ServSetup@1003 : Record 5911;
SalesSetup@1005 : Record 311;
ServiceChargeLineNo@1004 : Integer;
BEGIN
ServSetup.GET;
WITH ServiceLine DO BEGIN
IF RECORDLEVELLOCKING THEN
...

Replacement code 1

LOCAL PROCEDURE CalculateInvoiceDiscount@1(VAR ServHeader@1000 : Record 5900;VAR ServiceLine@1006 : Record 5902;VAR ServiceLine2@1001 : Record 5902);
VAR
TempVATAmountLine@1002 : TEMPORARY Record 290;
ServSetup@1003 : Record 5911;
SalesSetup@1005 : Record 311;

// Add the following line.
ServLineServChrg@1014 : Record 5902;

ServiceChargeLineNo@1004 : Integer;
BEGIN
ServSetup.GET;
WITH ServiceLine DO BEGIN
IF RECORDLEVELLOCKING THEN
...

Existing code 2

...
IF RECORDLEVELLOCKING THEN
LOCKTABLE;
ServHeader.TESTFIELD("Customer Posting Group");
CustPostingGr.GET(ServHeader."Customer Posting Group");

// Delete the following lines.
ServiceLine2.RESET;
ServiceLine2.SETRANGE("Document Type","Document Type");
ServiceLine2.SETRANGE("Document No.","Document No.");
ServiceLine2.SETRANGE("System-Created Entry",TRUE);
ServiceLine2.SETRANGE(Type,ServiceLine2.Type::"G/L Account");
ServiceLine2.SETRANGE("No.",CustPostingGr."Service Charge Acc.");
IF ServiceLine2.FIND('+') THEN BEGIN
ServiceChargeLineNo := ServiceLine2."Line No.";
ServiceLine2.VALIDATE("Unit Price",0);
ServiceLine2.MODIFY;
END;
// End of the lines.

ServiceLine2.RESET;
ServiceLine2.SETRANGE("Document Type","Document Type");
ServiceLine2.SETRANGE("Document No.","Document No.");
ServiceLine2.SETFILTER(Type,'<>0');
...

Replacement code 2

...
IF RECORDLEVELLOCKING THEN
LOCKTABLE;
ServHeader.TESTFIELD("Customer Posting Group");
CustPostingGr.GET(ServHeader."Customer Posting Group");

// Add the following lines.
ServLineServChrg.RESET;
ServLineServChrg.SETRANGE("Document Type","Document Type");
ServLineServChrg.SETRANGE("Document No.","Document No.");
ServLineServChrg.SETRANGE("System-Created Entry",TRUE);
ServLineServChrg.SETRANGE(Type,ServLineServChrg.Type::"G/L Account");
ServLineServChrg.SETRANGE("No.",CustPostingGr."Service Charge Acc.");
IF ServLineServChrg.FIND('+') THEN
ServiceChargeLineNo := ServLineServChrg."Line No.";
// End of the lines.

ServiceLine2.RESET;
ServiceLine2.SETRANGE("Document Type","Document Type");
ServiceLine2.SETRANGE("Document No.","Document No.");
ServiceLine2.SETFILTER(Type,'<>0');
...

Existing code 3

...
ELSE
Currency.GET(ServHeader."Currency Code");
IF TemporaryHeader THEN
ServiceLine2.SetServHeader(ServHeader);
IF ServiceChargeLineNo <> 0 THEN BEGIN

// Delete the following lines.
ServiceLine2.GET("Document Type","Document No.",ServiceChargeLineNo);
IF ServHeader."Prices Including VAT" THEN
ServiceLine2.VALIDATE(
"Unit Price",
ROUND(
(1 + ServiceLine2."VAT %" / 100) * CustInvDisc."Service Charge",
Currency."Unit-Amount Rounding Precision"))
ELSE
ServiceLine2.VALIDATE("Unit Price",CustInvDisc."Service Charge");
ServiceLine2.MODIFY;
// End of the lines.

END ELSE BEGIN
ServiceLine2.RESET;
ServiceLine2.SETRANGE("Document Type","Document Type");
ServiceLine2.SETRANGE("Document No.","Document No.");
ServiceLine2.FIND('+');
...

Replacement code 3

...
ELSE
Currency.GET(ServHeader."Currency Code");
IF TemporaryHeader THEN
ServiceLine2.SetServHeader(ServHeader);
IF ServiceChargeLineNo <> 0 THEN BEGIN

// Add the following lines.
IF ServiceLine2.GET("Document Type","Document No.",ServiceChargeLineNo) THEN BEGIN
IF ServHeader."Prices Including VAT" THEN
ServiceLine2.VALIDATE(
"Unit Price",
ROUND(
(1 + ServiceLine2."VAT %" / 100) * CustInvDisc."Service Charge",
Currency."Unit-Amount Rounding Precision"))
ELSE
ServiceLine2.VALIDATE("Unit Price",CustInvDisc."Service Charge");
ServiceLine2.MODIFY;
END;
// End of the lines.

END ELSE BEGIN
ServiceLine2.RESET;
ServiceLine2.SETRANGE("Document Type","Document Type");
ServiceLine2.SETRANGE("Document No.","Document No.");
ServiceLine2.FIND('+');
...

Existing code 4

...
Currency."Unit-Amount Rounding Precision"))
ELSE
ServiceLine2.VALIDATE("Unit Price",CustInvDisc."Service Charge");
ServiceLine2."System-Created Entry" := TRUE;
ServiceLine2.INSERT;
END;
ServiceLine2.CalcVATAmountLines(0,ServHeader,ServiceLine2,TempVATAmountLine, FALSE);
END ELSE
IF ServiceChargeLineNo <> 0 THEN BEGIN
ServiceLine2.GET("Document Type","Document No.",ServiceChargeLineNo);
...

Replacement code 4

...
Currency."Unit-Amount Rounding Precision"))
ELSE
ServiceLine2.VALIDATE("Unit Price",CustInvDisc."Service Charge");
ServiceLine2."System-Created Entry" := TRUE;
ServiceLine2.INSERT;

// Add the following lines.
ServLineServChrg := ServiceLine2;
IF NOT ServLineServChrg.FIND THEN
ServLineServChrg.INSERT;
// End of the lines.

END;
ServiceLine2.CalcVATAmountLines(0,ServHeader,ServiceLine2,TempVATAmountLine, FALSE);
END ELSE
IF ServiceChargeLineNo <> 0 THEN BEGIN
ServiceLine2.GET("Document Type","Document No.",ServiceChargeLineNo);
...

Prerequisites

You must have one of the following products installed to apply this hotfix:

Microsoft Dynamics NAV 2009 R2
Microsoft Dynamics NAV 2009 Service Pack 1

Removal information

You cannot remove this hotfix.

Status

Microsoft has confirmed that this is a problem in the Microsoft products that are listed in the "Applies to" section.

Note This is a "FAST PUBLISH" article created directly from within the Microsoft support organization. The information contained herein is provided as-is in response to emerging issues. As a result of the speed in making it available, the materials may include typographical errors and may be revised at any time without notice. See Terms of Use for other considerations.

Multiple service charge lines are generated unexpectedly when you partly ship a service order in Microsoft Dynamics NAV 2009

Symptoms

Resolution

Hotfix information

Installation information

Code changes

Prerequisites

Removal information

Status

Need more help?

Want more options?

Was this information helpful?

Thank you for your feedback!