You can create more than one inventory picks for a sales order unexpectedly if the Shipping Advice field in the sales order is set to Complete in Microsoft Dynamics NAV 2009 Service Pack 1

Hotfix information

A supported hotfix is now available from Microsoft. However, it is only intended to correct the problem that is described in this article. Apply it only to systems that are experiencing this specific problem. This hotfix may receive additional testing. Therefore, if you are not severely affected by this problem, we recommend that you wait for the next Microsoft Dynamics NAV service pack or the next Microsoft Dynamics NAV version that contains this hotfix.

Note In special cases, charges that are ordinarily incurred for support calls may be canceled if a Technical Support Professional for Microsoft Dynamics and related products determines that a specific update will resolve your problem. The usual support costs will apply to additional support questions and issues that do not qualify for the specific update in question.

Code changes

Note Always test code fixes in a controlled environment before you apply the fixes to your production computers.
To resolve this problem, follow these steps:

1. Change the fields in the Sales Line table (37) as follow:
   Existing code

   ...
   
   CALCFIELDS("Reserved Qty. (Base)");
   
   TESTFIELD("Reserved Qty. (Base)",0);
   
   IF Type = Type::Item THEN
   
       WhseValidateSourceLine.SalesLineVerifyChange(Rec,xRec);
   
   END;
   
   TESTFIELD("Qty. Shipped Not Invoiced",0);
   
   TESTFIELD("Quantity Shipped",0);
   
   TESTFIELD("Shipment No.",'');
   
   
   
   TESTFIELD("Prepmt. Amt. Inv.",0);
   ...

   Replacement code

   ...
   
   CALCFIELDS("Reserved Qty. (Base)");
   
   TESTFIELD("Reserved Qty. (Base)",0);
   
   IF Type = Type::Item THEN
   
       WhseValidateSourceLine.SalesLineVerifyChange(Rec,xRec);
   
   END;
   
   //Add the following lines.
   IF Type = Type::Item THEN
   
       CheckWhseActivityExists;
   //End of the lines.
   
   TESTFIELD("Qty. Shipped Not Invoiced",0);
   
   TESTFIELD("Quantity Shipped",0);
   
   TESTFIELD("Shipment No.",'');
   
   
   
   TESTFIELD("Prepmt. Amt. Inv.",0);
   ...

2. Change the global variables in the Sales Line table (37) as follow:
   Existing code

   ...
           Text046@1105 : TextConst 'ENU=You cannot return more than the %1 units that you have shipped for %2 %3.';
   
           Text047@1106 : TextConst 'ENU=must be positive when %1 is not 0.';
   
           TrackingBlocked@1107 : Boolean;
   
           Text048@1108 : TextConst 'ENU=You cannot use item tracking on a %1 created from a %2.';
   
           Text049@1139 : TextConst 'ENU=cannot be %1.';
   
   
         PROCEDURE InitOutstanding@16();
   
         BEGIN
   
           IF "Document Type" IN ["Document Type"::"Return Order","Document Type"::"Credit Memo"] THEN BEGIN
   
             "Outstanding Quantity" := Quantity - "Return Qty. Received";
   ...

   Replacement code

   ...
           Text046@1105 : TextConst 'ENU=You cannot return more than the %1 units that you have shipped for %2 %3.';
   
           Text047@1106 : TextConst 'ENU=must be positive when %1 is not 0.';
   
           TrackingBlocked@1107 : Boolean;
   
           Text048@1108 : TextConst 'ENU=You cannot use item tracking on a %1 created from a %2.';
   
           Text049@1139 : TextConst 'ENU=cannot be %1.';
   
           //Add the following line.
           Text052@1022 : TextConst 'ENU=Because the value of the %1 field is %2, and warehouse activities exist, you cannot add a new item to this order. You can either change the %3 field to Partial or delete the warehouse activities.';
   
   
         PROCEDURE InitOutstanding@16();
   
         BEGIN
   
           IF "Document Type" IN ["Document Type"::"Return Order","Document Type"::"Credit Memo"] THEN BEGIN
   
             "Outstanding Quantity" := Quantity - "Return Qty. Received";
   ...

3. Change the code in the CheckWhseActivityExists function in the Sales Line table (37) as follow:
   Existing code

   ...
             IF "Qty. to Invoice" = 0 THEN
   
               EXIT(TRUE);
   
           EXIT(FALSE);
   
         END;
   
   
   
         BEGIN
   
         END.
   
       }
   
     }
   ...

   Replacement code

   ...
             IF "Qty. to Invoice" = 0 THEN
   
               EXIT(TRUE);
   
           EXIT(FALSE);
   
         END;
   
   
         //Add the following lines.
         PROCEDURE CheckWhseActivityExists@1011();
   
         VAR
   
           WhseActivityLine@1019 : Record 5767;
   
         BEGIN
   
           IF SalesHeader."Shipping Advice" = SalesHeader."Shipping Advice"::Complete THEN BEGIN
   
             WhseActivityLine.RESET;
   
             WhseActivityLine.SETCURRENTKEY("Source Type","Source Subtype","Source No.","Source Line No.","Source Subline No.");
   
             WhseActivityLine.SETRANGE("Source Type",DATABASE::"Sales Line");
   
             WhseActivityLine.SETRANGE("Source Subtype","Document Type");
   
             WhseActivityLine.SETRANGE("Source No.","Document No.");
   
             IF "Document Type" = "Document Type"::Order THEN
   
               WhseActivityLine.SETRANGE("Source Document",WhseActivityLine."Source Document"::"Sales Order");
   
             IF "Document Type" = "Document Type"::"Return Order" THEN
   
               WhseActivityLine.SETRANGE("Source Document",WhseActivityLine."Source Document"::"Sales Return Order");
   
             IF NOT WhseActivityLine.ISEMPTY THEN
   
               ERROR(Text052,SalesHeader.FIELDCAPTION("Shipping Advice"),SalesHeader."Shipping Advice",SalesHeader.FIELDCAPTION("Shipping Advice"));
   
           END;
   
         END;
         //End of the lines.
   
   
         BEGIN
   
         END.
   
       }
   
     }
   ...