The DTA Suggest Vendor Payment report (3010546) and the LSV Suggest Collection report (3010831) suggest incorrect lines in the Swiss version of Microsoft Dynamics NAV

Hotfix information

A supported hotfix is now available from Microsoft. However, it is only intended to correct the problem that is described in this article. Apply it only to systems that are experiencing this specific problem. This hotfix may receive additional testing. Therefore, if you are not severely affected by this problem, we recommend that you wait for the next Microsoft Dynamics NAV service pack or the next Microsoft Dynamics NAV version that contains this hotfix.

Note In special cases, charges that are ordinarily incurred for support calls may be canceled if a Technical Support Professional for Microsoft Dynamics and related products determines that a specific update will resolve your problem. The usual support costs will apply to additional support questions and issues that do not qualify for the specific update in question.

Code changes

Note Always test code fixes in a controlled environment before you apply the fixes to your production computers.
To resolve this problem, follow these steps:

1. Add a new global variable in the DTA Suggest Vendor Payment report (3010546), and then specify the variable as follows:

   • Name: VendorLedgEntryTemp@1150058

   • DataType: Record

   • Subtype: Vendor Ledger Entry

   • Temporary: Yes

2. Add a new text constant in the DTA Suggest Vendor Payment report (3010546), and then specify the constant as follows:

   • Name: Text50000@1150064

   • Constant value: ENU=There are one or more entries for which no payment suggestions have been made because the posting dates of the entries are later than the posting date in the DTA Suggest Vendor Payments batch job request window. Do you want to see the entries?

3. Add the following code in the OnPreReport trigger in the DTA Suggest Vendor Payment report (3010546):

   VendorLedgEntryTemp.DELETEALL;

4. Add the following code in the OnPostReport trigger in the DTA Suggest Vendor Payment report (3010546):

   COMMIT;
   IF NOT VendorLedgEntryTemp.ISEMPTY THEN
     IF CONFIRM(Text50000) THEN
       FORM.RUNMODAL(0,VendorLedgEntryTemp);

5. Change the code in the Vendor - OnPostDataItem trigger in the DTA Suggest Vendor Payment report (3010546) as follow:
   Existing code

   d.CLOSE;
   IF NoOfLinesInserted > 0 THEN BEGIN
     WriteBalAccountLine(ToGlLine);
     MESSAGE(Text011,NoOfLinesInserted,GlSetup."LCY Code",TotalAmtLCY);
     IF NoOfVendorsWithCM > 0 THEN
       MESSAGE(Text013 + Text014 + Text017,NoOfVendorsWithCM,VendWithCmTxt)
   END ELSE
     MESSAGE(Text018,FromDueDate,ToDueDate);

   Replacement code

   d.CLOSE;
   IF VendorLedgEntryTemp.ISEMPTY THEN BEGIN
     IF NoOfLinesInserted > 0 THEN BEGIN
       WriteBalAccountLine(ToGlLine);
       MESSAGE(Text011,NoOfLinesInserted,GlSetup."LCY Code",TotalAmtLCY);
       IF NoOfVendorsWithCM > 0 THEN
         MESSAGE(Text013 + Text014 + Text017,NoOfVendorsWithCM,VendWithCmTxt)
     END ELSE
       MESSAGE(Text018,FromDueDate,ToDueDate);
   END;

6. Change the code in the WritePmtSuggestLines function in the DTA Suggest Vendor Payment report (3010546) as follows:
   Existing code 1

   // CH2316.begin
    VendorLedgerEntryNo := VendEntry."Entry No.";
   // CH2316.end
   WITH ToGlLine DO BEGIN
     INIT;
   ...

   Replacement code 1

   IF VendEntry."Posting Date" <= PostDate THEN BEGIN // CH0001
     // CH2316.begin
     VendorLedgerEntryNo := VendEntry."Entry No.";
     // CH2316.end
     WITH ToGlLine DO BEGIN
       INIT;
   ...

   Existing code 2

   ...
   VendorLedgerEntry2.GET(VendorLedgerEntryNo);
   VendorLedgerEntry2."On Hold" := 'DTA';
   VendorLedgerEntry2."Accepted Payment Tolerance" := 0;
   VendorLedgerEntry2.MODIFY;
   // CH2316.END

   Replacement code 2

   ...
     VendorLedgerEntry2.GET(VendorLedgerEntryNo);
     VendorLedgerEntry2."On Hold" := 'DTA';
     VendorLedgerEntry2."Accepted Payment Tolerance" := 0;
     VendorLedgerEntry2.MODIFY;
   // CH2316.END
   END ELSE BEGIN
     VendorLedgEntryTemp := VendEntry;
     VendorLedgEntryTemp.INSERT;
   END;

7. Add a new global variable in the LSV Suggest Collection report (3010831), and then specify the variable as follows:

   • Name: TempCustLedgEntry@1150042

   • DataType: Record

   • Subtype: Customer Ledger Entry

   • Temporary: Yes

8. Add a new text constant in the LSV Suggest Collection report (3010831), and then specify the constant as follows:

   • Name: Text50000@1150064

   • Constant value: ENU=There are one or more entries for which no collection suggestions have been made because the posting dates of the entries are later than the collection date in the LSV Collect Suggestions batch job request window. Do you want to see the entries?

9. Change the code in the OnPreReport trigger in the the LSV Suggest Collection report (3010831) as follow:
   Existing code

   IF LsvJournal."LSV Bank Code" = '' THEN
     ERROR(Text020);

   Replacement code

   IF LsvJournal."LSV Bank Code" = '' THEN
     ERROR(Text020);
   TempCustLedgEntry.DELETEALL;

10. Add the following code in the OnPostReport trigger in the LSV Suggest Collection report (3010831):

    COMMIT;
    IF NOT TempCustLedgEntry.ISEMPTY THEN
      IF CONFIRM(Text50000) THEN
        FORM.RUNMODAL(0,TempCustLedgEntry);

11. Change the code in the Customer - OnPostDataItem trigger in the LSV Suggest Collection report (3010831) as follow:
    Existing code

    d.CLOSE;
    IF NoOfLinesInserted > 0 THEN BEGIN
      MESSAGE(Text007,NoOfLinesInserted,LsvSetup."LSV Currency Code",TotalAmt);
      IF LsvJournal."LSV Journal Description" = '' THEN BEGIN
        LsvJournal."LSV Journal Description" :=
          FORMAT(STRSUBSTNO(Text021,LsvSetup."LSV Currency Code",FromDueDate,ToDueDate,Customer.GETFILTERS)
            ,-MAXSTRLEN(LsvJournal."LSV Journal Description"));
      END;
      LsvJournal."Credit Date" := CollectionDate;
      LsvJournal.MODIFY;
      // CH2813.BEGIN
      IF NoOfCustWithCreditMemo > 0 THEN
        IF NOT CONFIRM(Text009 + Text010 + Text012 + Text013,TRUE,NoOfCustWithCreditMemo,CustCreditMemoTxt) THEN
          ERROR(Text014);
      // CH2813.END
    END ELSE
      MESSAGE(Text015,FromDueDate,ToDueDate);

    Replacement code

    d.CLOSE;
    IF TempCustLedgEntry.ISEMPTY THEN BEGIN // CH0001
      IF NoOfLinesInserted > 0 THEN BEGIN
        MESSAGE(Text007,NoOfLinesInserted,LsvSetup."LSV Currency Code",TotalAmt);
        IF LsvJournal."LSV Journal Description" = '' THEN BEGIN
          LsvJournal."LSV Journal Description" :=
            FORMAT(STRSUBSTNO(Text021,LsvSetup."LSV Currency Code",FromDueDate,ToDueDate,Customer.GETFILTERS)
              ,-MAXSTRLEN(LsvJournal."LSV Journal Description"));
        END;
        LsvJournal."Credit Date" := CollectionDate;
        LsvJournal.MODIFY;
        // CH2813.BEGIN
        IF NoOfCustWithCreditMemo > 0 THEN
          IF NOT CONFIRM(Text009 + Text010 + Text012 + Text013,TRUE,NoOfCustWithCreditMemo,CustCreditMemoTxt) THEN
            ERROR(Text014);
        // CH2813.END
      END ELSE
        MESSAGE(Text015,FromDueDate,ToDueDate);
    END;

12. Change the code in the WritePmtSuggestLines function in the LSV Suggest Collection report (3010831) as follows:
    Existing code 1

    // Collection amt: Cust. Entry amount - Cash disc. possible
    WITH ToLSVJourLine DO BEGIN
      // Ensure, that the Entry is only once in the LSV Journal Line
      LSVJourLineCheck.SETCURRENTKEY("Applies-to Doc. No.");
      LSVJourLineCheck.SETRANGE("Applies-to Doc. No.",ActCustLedgEntry."Document No.");
    ...

    Replacement code 1

    // Collection amt: Cust. Entry amount - Cash disc. possible
    WITH ToLSVJourLine DO BEGIN
      IF CustLedgEntry."Posting Date" <= CollectionDate THEN BEGIN
        // Ensure, that the Entry is only once in the LSV Journal Line
        LSVJourLineCheck.SETCURRENTKEY("Applies-to Doc. No.");
        LSVJourLineCheck.SETRANGE("Applies-to Doc. No.",ActCustLedgEntry."Document No.");
    ...

    Existing code 2

    ...
      TotalAmt := TotalAmt + "Collection Amount";
      d.UPDATE(3,TotalAmt);
      // CH2813.BEGIN
      EntriesPerCust := EntriesPerCust + 1;
      // CH2813.END
    END;

    Replacement code 2

    ...
        TotalAmt := TotalAmt + "Collection Amount";
        d.UPDATE(3,TotalAmt);
        // CH2813.BEGIN
        EntriesPerCust := EntriesPerCust + 1;
        // CH2813.END
    
    //Add the follong lines.
      END ELSE BEGIN
        TempCustLedgEntry := CustLedgEntry;
        TempCustLedgEntry.INSERT;
      END;
    //End of the lines.
    
    END;