Incorrect valuation date is reported when you post multiple outputs for the same production order for an item that uses the Average costing method in Microsoft Dynamics NAV 2009

This article applies to Microsoft Dynamics NAV for all countries and all language locales.

Symptoms

Consider the following scenario in Microsoft Dynamics NAV:

  • You apply hotfix 2533593 or hotfix 2781950.

  • You set the Costing Method field to Average for an item in the Item Card dialog box.

  • You set the Costing Method field to Average for a component for the item in the Item Card dialog box.

  • You post multiple outputs for the same production order for the item in different average cost periods.

  • You run the "Adjust cost item entries" batch job for the item.

  • You view the "Average Cost Calc. Overview" report for the item.

In this scenario, the valuation date is incorrect. This problem occurs in the following products:

  • Microsoft Dynamics NAV 2009 R2

  • Microsoft Dynamics NAV 2009 Service Pack 1

For more information about hotfix 2533593, click the following article number to view the article in the Microsoft Knowledge Base:

2533593 The Adjust Cost Item Entry (ACIE) goes into a loop when you run the ACIE process in Microsoft Dynamics NAV 2009 SP1 or in Microsoft Dynamics NAV 2009 R2 For more information about hotfix 2781950, click the following article number to view the article in the Microsoft Knowledge Base:

2781950 A costing hotfix rollup is available for Microsoft Dynamics NAV 2009

Resolution

Hotfix information

A supported hotfix is now available from Microsoft. However, it is only intended to correct the problem that is described in this article. Apply it only to systems that are experiencing this specific problem. This hotfix may receive additional testing. Therefore, if you are not severely affected by this problem, we recommend that you wait for the next Microsoft Dynamics NAV 2009 service pack or the next Microsoft Dynamics NAV version that contains this hotfix.

Note In special cases, charges that are ordinarily incurred for support calls may be canceled if a Technical Support Professional for Microsoft Dynamics and related products determines that a specific update will resolve your problem. The usual support costs will apply to additional support questions and issues that do not qualify for the specific update in question.



Installation information

Microsoft provides programming examples for illustration only, without warranty either expressed or implied. This includes, but is not limited to, the implied warranties of merchantability or fitness for a particular purpose. This article assumes that you are familiar with the programming language that is being demonstrated and with the tools that are used to create and to debug procedures. Microsoft support engineers can help explain the functionality of a particular procedure, but they will not modify these examples to provide added functionality or construct procedures to meet your specific requirements.

Note Before you install this hotfix, verify that all Microsoft Navision client users are logged off the system. This includes Microsoft Navision Application Services (NAS) client users. You should be the only client user who is logged on when you implement this hotfix.

To implement this hotfix, you must have a developer license.

We recommend that the user account in the Windows Logins window or in the Database Logins window be assigned the "SUPER" role ID. If the user account cannot be assigned the "SUPER" role ID, you must verify that the user account has the following permissions:

  • The Modify permission for the object that you will be changing.

  • The Execute permission for the System Object ID 5210 object and for the System Object ID 9015 object.



Note You do not have to have rights to the data stores unless you have to perform data repair.

Code changes

Note Always test code fixes in a controlled environment before you apply the fixes to your production computers.
To resolve this problem, follow these steps:

  1. Change the code in the RunWithCheck function in the "Item Jnl.-Post Line" codeunit (22) as follows:
    Existing code

    ...
    ItemJnlLine2 := ItemJnlLine;
    RedoApplications;
    ...

    Replacement code

    ...
    ItemJnlLine2 := ItemJnlLine;

    // Add the following line.
    CorrectOutputValuationDate(GlobalItemLedgEntry);

    RedoApplications;
    ...
  2. Change the code in the PostItem function in the "Item Jnl.-Post Line" codeunit (22) as follows:
    Existing code

    ...
    GlobalItemLedgEntry.GET("Applies-to Entry");
    InitValueEntry(GlobalValueEntry,GlobalItemLedgEntry);
    ...

    Replacement code

    ...
    GlobalItemLedgEntry.GET("Applies-to Entry");

    // Add the following line.
    CorrectOutputValuationDate(GlobalItemLedgEntry);

    InitValueEntry(GlobalValueEntry,GlobalItemLedgEntry);
    ...
  3. Change the code in the InsertValueEntry function in the "Item Jnl.-Post Line" codeunit (22) as follows:
    Existing code 1

    ...
    CalcExpectedCost(
    ItemLedgEntry."Entry No.",
    ...

    Replacement code 1

    ...
    CalcExpectedCost(

    // Add the following line.
    ValueEntry,

    ItemLedgEntry."Entry No.",
    ...

    Existing code 2

    ...
    ItemLedgEntry.Quantity = ItemLedgEntry."Invoiced Quantity");
    ...

    Replacement code 2

    ...
    ItemLedgEntry.Quantity = ItemLedgEntry."Invoiced Quantity");

    // Add the following line.
    END;
    ...

    Existing code 3

    ...
    // Delete the following lines.
    IF (InvdValueEntry."Cost Amount (Expected)" <> 0) AND (ValueEntry."Cost Amount (Expected)" <> 0) THEN
    ValueEntry."Cost Amount (Expected)" :=
    ValueEntry."Cost Amount (Expected)" - InvdValueEntry."Cost Amount (Expected)";
    IF (InvdValueEntry."Cost Amount (Expected) (ACY)" <> 0) AND (ValueEntry."Cost Amount (Expected) (ACY)" <> 0) THEN
    ValueEntry."Cost Amount (Expected) (ACY)" :=
    ValueEntry."Cost Amount (Expected) (ACY)" - InvdValueEntry."Cost Amount (Expected) (ACY)";
    END;
    // End of the lines.

    IF ValueEntry.Inventoriable THEN
    PostInventoryToGL(ValueEntry);
    ...

    Replacement code 3

    ...
    IF ValueEntry.Inventoriable THEN
    PostInventoryToGL(ValueEntry);
    ...
  4. Change the code in the UpdateValuationDate function in the "Item Jnl.-Post Line" codeunit (22) as follows:
    Existing code

    ...
    ToValueEntry2.FIND('-');

    // Delete the following lines.
    IF FromInbound THEN
    ToValueEntry2.MODIFYALL("Valuation Date",FromValuationDate)
    ELSE
    // End of the lines.

    REPEAT
    ...

    Replacement code

    ...
    ToValueEntry2.FIND('-');

    // Add the following lines.
    IF FromInbound THEN BEGIN
    IF ToValueEntry2."Valuation Date" < FromValuationDate THEN
    ToValueEntry2.MODIFYALL("Valuation Date",FromValuationDate);
    END ELSE
    // End of the lines.

    REPEAT
    ...
  5. Change the code in the CalcExpectedCost function in the "Item Jnl.-Post Line" codeunit (22) as follows:
    Existing codeĀ 1

    ...
    // Delete the following line.
    LOCAL PROCEDURE CalcExpectedCost@60(ItemLedgEntryNo@1003 : Integer;InvoicedQty@1006 : Decimal;Quantity@1005 : Decimal;VAR ExpectedCost@1001 : Decimal;VAR ExpectedCostACY@1002 : Decimal;VAR ExpectedSalesAmt@1007 : Decimal;VAR ExpectedPurchAmt@1008 : Decimal;CalcReminder@1004 : Boolean);

    VAR
    ...

    Replacement codeĀ 2

    ...
    // Add the following line.
    LOCAL PROCEDURE CalcExpectedCost@60(VAR InvdValueEntry@1009 : Record 5802;ItemLedgEntryNo@1003 : Integer;InvoicedQty@1006 : Decimal;Quantity@1005 : Decimal;VAR ExpectedCost@1001 : Decimal;VAR ExpectedCostACY@1002 : Decimal;VAR ExpectedSalesAmt@1007 : Decimal;VAR ExpectedPurchAmt@1008 : Decimal;CalcReminder@1004 : Boolean);

    VAR
    ...

    Existing code 2

    ...
    END
    END ELSE BEGIN
    REPEAT
    IF "Expected Cost" THEN BEGIN
    ExpectedCost := ExpectedCost + "Cost Amount (Expected)";
    ExpectedCostACY := ExpectedCostACY + "Cost Amount (Expected) (ACY)";
    IF NOT CalledFromAdjustment THEN BEGIN
    ExpectedSalesAmt := ExpectedSalesAmt + "Sales Amount (Expected)";
    ExpectedPurchAmt := ExpectedPurchAmt + "Purchase Amount (Expected)";
    END;
    END;
    UNTIL NEXT = 0;
    ExpectedCost :=
    CalcExpCostToBalance(ExpectedCost,InvoicedQty,Quantity,GLSetup."Amount Rounding Precision");
    ExpectedCostACY :=
    CalcExpCostToBalance(ExpectedCostACY,InvoicedQty,Quantity,Currency."Amount Rounding Precision");
    IF NOT CalledFromAdjustment THEN BEGIN
    ExpectedSalesAmt :=
    CalcExpCostToBalance(ExpectedSalesAmt,InvoicedQty,Quantity,GLSetup."Amount Rounding Precision");
    ExpectedPurchAmt :=
    CalcExpCostToBalance(ExpectedPurchAmt,InvoicedQty,Quantity,GLSetup."Amount Rounding Precision");
    END;
    END;
    END;
    END;
    ...

    Replacement code 2

    ...
    END

    // Add the following lines.
    END ELSE
    IF InvdValueEntry.Adjustment AND
    (InvdValueEntry."Entry Type" = InvdValueEntry."Entry Type"::"Direct Cost")
    THEN BEGIN
    ExpectedCost := -InvdValueEntry."Cost Amount (Actual)";
    ExpectedCostACY := -InvdValueEntry."Cost Amount (Actual) (ACY)";
    IF NOT CalledFromAdjustment THEN BEGIN
    ExpectedSalesAmt := -InvdValueEntry."Sales Amount (Actual)";
    ExpectedPurchAmt := -InvdValueEntry."Purchase Amount (Actual)";
    END
    // End of the lines.

    END ELSE BEGIN
    REPEAT
    IF "Expected Cost" THEN BEGIN
    ExpectedCost := ExpectedCost + "Cost Amount (Expected)";
    ExpectedCostACY := ExpectedCostACY + "Cost Amount (Expected) (ACY)";
    IF NOT CalledFromAdjustment THEN BEGIN
    ExpectedSalesAmt := ExpectedSalesAmt + "Sales Amount (Expected)";
    ExpectedPurchAmt := ExpectedPurchAmt + "Purchase Amount (Expected)";
    END;
    END;
    UNTIL NEXT = 0;
    ExpectedCost :=
    CalcExpCostToBalance(ExpectedCost,InvoicedQty,Quantity,GLSetup."Amount Rounding Precision");
    ExpectedCostACY :=
    CalcExpCostToBalance(ExpectedCostACY,InvoicedQty,Quantity,Currency."Amount Rounding Precision");
    IF NOT CalledFromAdjustment THEN BEGIN
    ExpectedSalesAmt :=
    CalcExpCostToBalance(ExpectedSalesAmt,InvoicedQty,Quantity,GLSetup."Amount Rounding Precision");
    ExpectedPurchAmt :=
    CalcExpCostToBalance(ExpectedPurchAmt,InvoicedQty,Quantity,GLSetup."Amount Rounding Precision");
    END;
    END;
    END;
    END;
    ...
  6. Change the code in the CorrectOutputValuationDate function in the "Item Jnl.-Post Line" codeunit (22) as follows:
    Existing code

    ...
    BEGIN
    ...

    Replacement code

    ...
    // Add the following lines.
    LOCAL PROCEDURE CorrectOutputValuationDate@85(ItemLedgerEntry@1000 : Record 32);
    VAR
    ValueEntry@1001 : Record 5802;
    TempValueEntry@1002 : TEMPORARY Record 5802;
    ValuationDate@1004 : Date;
    // End of the lines.

    BEGIN
    ...
  7. Change the code in the GetSourceNo function in the "Item Jnl.-Post Line" codeunit (22) as follows:
    Existing code

    ...
    BEGIN
    END.
    }
    }
    ...

    Replacement code

    ...
    BEGIN

    // Add the following lines.
    IF NOT (ItemLedgerEntry."Entry Type" IN [ItemLedgerEntry."Entry Type"::Consumption,ItemLedgerEntry."Entry Type"::Output]) THEN
    EXIT;
    ValuationDate := MaxConsumptionValuationDate(ItemLedgerEntry."Prod. Order No.");
    ValueEntry.SETCURRENTKEY("Prod. Order No.");
    ValueEntry.SETRANGE("Prod. Order No.",ItemLedgerEntry."Prod. Order No.");
    ValueEntry.SETRANGE("Item Ledger Entry Type",ValueEntry."Item Ledger Entry Type"::Output);
    IF ValueEntry.FIND('-') THEN
    REPEAT
    IF ItemUsedInConsumption(ValueEntry) THEN BEGIN
    TempValueEntry := ValueEntry;
    TempValueEntry.INSERT;
    END;
    UNTIL ValueEntry.NEXT = 0;
    UpdateOutputEntryAndChain(TempValueEntry,ValuationDate);
    END;
    LOCAL PROCEDURE MaxConsumptionValuationDate@86(ProdOrderNo@1000 : Code[20]) : Date;
    VAR
    ValueEntry@1001 : Record 5802;
    ValuationDate@1002 : Date;
    BEGIN
    ValueEntry.SETCURRENTKEY("Prod. Order No.");
    ValueEntry.SETRANGE("Prod. Order No.",ProdOrderNo);
    ValueEntry.SETRANGE("Item Ledger Entry Type",ValueEntry."Item Ledger Entry Type"::Consumption);
    IF ValueEntry.FIND('-') THEN
    REPEAT
    IF (ValueEntry."Valuation Date" > ValuationDate) AND
    (ValueEntry."Entry Type" <> ValueEntry."Entry Type"::Revaluation)
    THEN
    ValuationDate := ValueEntry."Valuation Date";
    UNTIL ValueEntry.NEXT = 0;
    EXIT(ValuationDate);
    END;
    LOCAL PROCEDURE UpdateOutputEntryAndChain@87(VAR TempValueEntry@1000 : TEMPORARY Record 5802;ValuationDate@1001 : Date);
    VAR
    ValueEntry@1002 : Record 5802;
    ItemLedgerEntryNo@1003 : Integer;
    BEGIN
    TempValueEntry.SETCURRENTKEY("Item Ledger Entry No.","Entry Type");
    IF TempValueEntry.FIND('-') THEN
    REPEAT
    ValueEntry.GET(TempValueEntry."Entry No.");
    IF ValueEntry."Valuation Date" < ValuationDate THEN BEGIN
    IF ItemLedgerEntryNo <> TempValueEntry."Item Ledger Entry No." THEN BEGIN
    ItemLedgerEntryNo := TempValueEntry."Item Ledger Entry No.";
    UpdateLinkedValuationDate(ValuationDate,ItemLedgerEntryNo,TRUE);
    END;
    ValueEntry."Valuation Date" := ValuationDate;
    ValueEntry.MODIFY;
    IF ValueEntry."Entry No." = DirCostValueEntry."Entry No." THEN
    DirCostValueEntry := ValueEntry;
    END;
    UNTIL TempValueEntry.NEXT = 0;
    END;
    LOCAL PROCEDURE ItemUsedInConsumption@88(OutputValueEntry@1170000000 : Record 5802) : Boolean;
    VAR
    ValueEntry@1170000001 : Record 5802;
    BEGIN
    WITH ValueEntry DO BEGIN
    SETCURRENTKEY("Prod. Order No.");
    SETRANGE("Prod. Order No.",OutputValueEntry."Prod. Order No.");
    SETRANGE("Item No.",OutputValueEntry."Item No.");
    SETRANGE("Item Ledger Entry Type","Item Ledger Entry Type"::Consumption);
    EXIT(NOT ISEMPTY);
    END;
    END;
    BEGIN
    // End of the lines.

    END.
    }
    }
    ...


Prerequisites

You must have one of the following products installed to apply this hotfix:

  • Microsoft Dynamics NAV 2009 R2

  • Microsoft Dynamics NAV 2009 Service Pack 1

Removal information

You cannot remove this hotfix.

Status

Microsoft has confirmed that this is a problem in the Microsoft products that are listed in the "Applies to" section.

Note This is a "FAST PUBLISH" article created directly from within the Microsoft support organization. The information contained herein is provided as-is in response to emerging issues. As a result of the speed in making it available, the materials may include typographical errors and may be revised at any time without notice. See Terms of Use for other considerations.

Need more help?

Expand your skills
Explore Training
Get new features first
Join Microsoft Insiders

Was this information helpful?

Thank you for your feedback!

Thank you for your feedback! It sounds like it might be helpful to connect you to one of our Office support agents.

×